Is this good or bad programming?

September 1, 2010

(This article was first published on mikeksmith's posterous, and kindly contributed to R-bloggers)

If I come across this kind of code when I’m checking (QCing) code it makes me want to punch the programmer’s face. I find that it’s impossible to step through and check each dataset with the previous incarnation. Which is how I check what has happened in between lines. (In this case the changes are trivial, but the principle applies). However when I discussed it with a colleague recently he said “No, I think this is cool. Your final dataset is still called ‘data’ and you can easily see what changes have been made between the input and the final version ready for analysis.”

data <- read.csv(“foo.csv”)
data <- data[data$STUDY == 1234,]
data <- data[!$VAR),]
data <- data[data$VAR > 0,]
 data$VAR<- log(data$VAR)

So. Is this cool? Or really, really bad?



| Leave a comment  »

To leave a comment for the author, please follow the link and comment on their blog: mikeksmith's posterous. offers daily e-mail updates about R news and tutorials on topics such as: Data science, Big Data, R jobs, visualization (ggplot2, Boxplots, maps, animation), programming (RStudio, Sweave, LaTeX, SQL, Eclipse, git, hadoop, Web Scraping) statistics (regression, PCA, time series, trading) and more...

If you got this far, why not subscribe for updates from the site? Choose your flavor: e-mail, twitter, RSS, or facebook...

Comments are closed.


Never miss an update!
Subscribe to R-bloggers to receive
e-mails with the latest R posts.
(You will not see this message again.)

Click here to close (This popup will not appear again)